chore: add notes on adding gateway on a vlab #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergei Lukianov <[email protected]>
|
🚀 Deployed on https://preview-224--hedgehog-docs.netlify.app |
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for the gateway feature in vlab, explaining how to enable it and what resources it requires.
- Adds a new "Gateway" section in the running documentation explaining how to add a gateway using the
--gatewayflag - Updates the system requirements table to include gateway resource specifications (8 vCPUs, 6GB RAM, 50GB disk)
- Adds a note about additional resource requirements when gateway is enabled
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/vlab/running.md | Adds new Gateway section documenting how to enable and configure gateway connectivity |
| docs/vlab/overview.md | Updates system requirements to include gateway resource specifications |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+280
to
+281
| Gateway could be added by adding `--gateway` flag to the `hhfab init` command and it'll be automatically added connected | ||
| to two spines in case of spine-leaf topology or two leafs in case of the mesh topology, number of uplinks could be |
There was a problem hiding this comment.
Several grammatical issues in this paragraph:
- "could be added" → "can be added" (more direct)
- "added connected" → "connected"
- "leafs" → "leaves" (correct plural)
- Missing article: "number of uplinks" → "the number of uplinks"
- "could be controlled" → "can be controlled" (consistency)
Suggested change
| Gateway could be added by adding `--gateway` flag to the `hhfab init` command and it'll be automatically added connected | |
| to two spines in case of spine-leaf topology or two leafs in case of the mesh topology, number of uplinks could be | |
| Gateway can be added by adding the `--gateway` flag to the `hhfab init` command, and it will be automatically connected | |
| to two spines in the case of spine-leaf topology or two leaves in the case of the mesh topology. The number of uplinks can be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.