-
Notifications
You must be signed in to change notification settings - Fork 8
Add gateway peering examples to the VLAB demo section #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Emanuele Di Pascale <[email protected]>
|
🚀 Deployed on https://preview-229--hedgehog-docs.netlify.app |
9dde86c to
5189d93
Compare
|
@edipascale yeah, I think it's a good idea to add info on the virt externals and add examples of using them with both ExternalPeerings and gw Peerings. It could probably be a separate page under the VLAB section as existing ones are already quite loaded. |
5189d93 to
bc97650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive documentation for gateway peering examples in the VLAB demo section, including VPC peering with stateless and stateful NAT. Additionally, it removes the "experimental" designation from mesh topology references.
- Adds gateway peering documentation with practical NAT examples
- Updates CLI help text to include new options for gateway peering
- Removes "experimental" label from mesh topology feature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/vlab/demo.md | Adds new section on gateway peerings and NAT with practical examples, updates CLI help text for setup commands, includes examples of stateless and stateful NAT configurations |
| docs/vlab/running.md | Removes "experimental" designation from mesh topology description |
| docs/vlab/overview.md | Removes "experimental" designation from mesh topology description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Emanuele Di Pascale <[email protected]>
bc97650 to
f807899
Compare
Fix #228
@Frostman I'm unclear whether we should also add documentation for external peering via gateway, seeing as we never documented virtual externals in the VLAB - if needed I can do both things in a separate PR