FAQ #45
Merged
FAQ #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbojangles3
requested review from
Frostman,
amitlimaye,
sergeymatov,
sonoble and
thedvorkin
as code owners
|
🚀 Deployed on https://preview-45--hedgehog-docs.netlify.app |
qmonnet
requested changes
Nov 25, 2024
Member
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
Looks good overall, I've got some minor suggestions below.
mrbojangles3
force-pushed
the
faq-and-other-fixes
branch
from
7df7008 to
73d62c8
Compare
qmonnet
requested changes
Nov 26, 2024
Member
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
Some typos left, but looks good otherwise, thanks!
mrbojangles3
force-pushed
the
faq-and-other-fixes
branch
from
2f34937 to
e178ec6
Compare
Co-authored-by: Quentin Monnet <[email protected]>
qmonnet
requested changes
Dec 2, 2024
Member
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
What is the Hedgehog Fabric?
This is really bugging me to have the “Hedgehog Fabric” at the top of the page when the title of the docs says “Open Network Fabric”. As discussed, we'll really need to have this discussion about the naming at some point.
Otherwise looks good, with another batch of minor suggestions 🙂. Nice work!
Co-authored-by: Quentin Monnet <[email protected]>
Member
|
Now that I'm in the owner teams, you've got all reviews required to merge this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47