-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example wiring diagram #77
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Logan Blyth <[email protected]>
🚀 Deployed on https://preview-77--hedgehog-docs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find some small suggestions below.
Why is your commit title “initial commit”?
apiVersion: wiring.githedgehog.com/v1beta1 | ||
kind: Switch | ||
metadata: | ||
name: ds3000-02 | ||
spec: | ||
boot: | ||
serial: ABC123XYZ | ||
serial: ABC123XYZ # (1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serial: ABC123XYZ # (1) | |
serial: ABC123XYZ # or we can also use "mac: 34:AD:61:00:02:03" |
And get rid of the (somewhat) confusing footnote?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am glad you brought this up. The footnote is something that I though would help, it is good to know that it doesn't. There are other docs that use the footnote style for YAML explanation. Which is what inspired this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, the indication itself is useful. Having the footnote right below the YAML sample is OK, but looking at the example you link, I note that:
- the footnote reference and indicator are the same, both blue circles
- the marker is clickable, making it easier to find what part of the doc refers to it
- the note is too big to hold conveniently in a comment on the same line in the YAML sample, which is not really the case here so I'd just as well add the note in the comment, but that's me 🤷
In your case, I would at least make sure to use the same syntax at both locations if you want to keep the footnote, either (1)
or 1.
, but not a mix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By “confusing” I mostly meant that it was not super easy to find the footnote that it refers to; much of the confusion goes away if you use the same (1)
syntax at both locations for example. I did not mean that the content of the note itself was confusing.
Co-authored-by: Quentin Monnet <[email protected]>
The commit message is because I was rushing, I will change it. |
Signed-off-by: Pau Capdevila <[email protected]>
You could take the opportunity to refer to the line number instead, now that you are introducing them I pushed a commit fixing a small typo. Probably on another PR:
|
If we are okay with referring to line numbers I am good with switching to them. There is also the option to have the line numbers start at a given number. So we could have a big listing then break it up in sections to talk about it. Thoughts @pau-hedgehog and @qmonnet |
I don't know. Is there a way to reference a specific line an turns that ref into a number under the YAML sample, or do you manually reference the line number, and risks the line number getting outdated if someone inserts more lines into the YAML snippet in the future? |
It would be a pretty manual process. We would take the example file and have to manual start the line numbers ourselves. Very easy to get out of sync. |
I'm still in favour of the footnote (or inline comment) in that case 😅. |
What do you think of the look on the material for mkdocs webpage - https://squidfunk.github.io/mkdocs-material/reference/code-blocks/#adding-annotations. It doesn't seem like we are getting the same functionality that is shown on the page. |
Ooooh so that's what you were trying to do! That's cool, now we just need to understand how to make it work 🙂 |
Try adding a blank line between the YAML snippet and the annotation, just in case? |
We may be missing this: https://github.com/pawamoy/mkdocs-pygments ? |
It was the blank line. Had to step away will update when back.
Logan Blyth
…On Fri, Mar 21, 2025 at 11:31 AM Pau Capdevila ***@***.***> wrote:
What do you think of the look on the material for mkdocs webpage -
https://squidfunk.github.io/mkdocs-material/reference/code-blocks/#adding-annotations.
It doesn't seem like we are getting the same functionality that is shown on
the page.
image.png (view on web)
<https://github.com/user-attachments/assets/d5dc71e4-57a7-4af1-b814-caadd38ff0cf>
We may be missing this: https://github.com/pawamoy/mkdocs-pygments ?
—
Reply to this email directly, view it on GitHub
<#77 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXI6A54RWTWYNYFQJG5JL2VQWGDAVCNFSM6AAAAABZL3QKUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBTG4ZTCMRSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: pau-hedgehog]*pau-hedgehog* left a comment (githedgehog/docs#77)
<#77 (comment)>
What do you think of the look on the material for mkdocs webpage -
https://squidfunk.github.io/mkdocs-material/reference/code-blocks/#adding-annotations.
It doesn't seem like we are getting the same functionality that is shown on
the page.
image.png (view on web)
<https://github.com/user-attachments/assets/d5dc71e4-57a7-4af1-b814-caadd38ff0cf>
We may be missing this: https://github.com/pawamoy/mkdocs-pygments ?
—
Reply to this email directly, view it on GitHub
<#77 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXI6A54RWTWYNYFQJG5JL2VQWGDAVCNFSM6AAAAABZL3QKUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBTG4ZTCMRSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: Logan Blyth <[email protected]>
Signed-off-by: Logan Blyth <[email protected]>
also experiment with adding line numbers for listings