bgp simplification #991
Draft
bgp simplification #991
+130
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifically disableConnectedCheck and updateSource, needed for the new simplified config Signed-off-by: Emanuele Di Pascale <[email protected]>
Signed-off-by: Emanuele Di Pascale <[email protected]>
|
🚀 Temp artifacts published: |
Frostman
reviewed
Jul 18, 2025
| @@ -405,6 +409,64 @@ func planFabricConnections(agent *agentapi.Agent, spec *dozer.Spec) error { | |||
| }, | |||
| } | |||
|
|
|||
| // for spines, we want to advertise every /32 in the service IP range | |||
| // for leaves, we want to advertise only the switch's own VTEP IP | |||
| var servicePrefix string | |||
There was a problem hiding this comment.
why is it different between spines and leafs? shouldn't we always advertise protocol IP regardless of the role and on top of it VTEP IP for leafs?
| } | ||
| ipStr := ip.String() | ||
| allowasIn := agent.Spec.Switch.Redundancy.Type == meta.RedundancyTypeMCLAG | ||
| if _, exists := spec.VRFs[VRFDefault].BGP.Neighbors[ipStr]; !exists { |
There was a problem hiding this comment.
It can already exist only if we're facing a switching with the same protocol IP which shouldn't be possible but even if it is the neighbor config is exactly the same so no need to do a check
| @@ -1108,10 +1205,6 @@ func planDefaultVRFWithBGP(agent *agentapi.Agent, spec *dozer.Spec) error { | |||
| Enabled: true, | |||
| MaxPaths: pointer.To(getMaxPaths(agent)), | |||
| }, | |||
| L2VPNEVPN: dozer.SpecVRFBGPL2VPNEVPN{ | |||
There was a problem hiding this comment.
Do we really don't need to enable EVPN & adrvertise all vni anymore?
| if value.UpdateSource != nil && *value.UpdateSource != "" { | ||
| bgpNeigh.Neighbor[name].Transport = &oc.OpenconfigNetworkInstance_NetworkInstances_NetworkInstance_Protocols_Protocol_Bgp_Neighbors_Neighbor_Transport{ | ||
| Config: &oc.OpenconfigNetworkInstance_NetworkInstances_NetworkInstance_Protocols_Protocol_Bgp_Neighbors_Neighbor_Transport_Config{ | ||
| LocalAddress: pointer.To(*value.UpdateSource), |
There was a problem hiding this comment.
you don't need to deref and take a ref to it again here, just pass value.UpdateSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.