This repository was archived by the owner on Jun 24, 2024. It is now read-only.
Fix ensure_submission_repository_exists for import_resiliency beta #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when import_resiliency_enabled?
houndci-bot
reviewed
Jul 18, 2018
| .github_repository | ||
| .present?(headers: GitHub::APIHeaders.no_cache_no_store) | ||
| .github_repository | ||
| .present?(headers: GitHub::APIHeaders.no_cache_no_store) |
There was a problem hiding this comment.
Layout/MultilineMethodCallIndentation: Align .present? with current_submission on line 96.
| @@ -94,13 +94,17 @@ def join_roster | |||
| def ensure_submission_repository_exists | |||
| return not_found unless current_submission | |||
| return if current_submission | |||
| .github_repository | |||
| .present?(headers: GitHub::APIHeaders.no_cache_no_store) | |||
| .github_repository | |||
There was a problem hiding this comment.
Layout/MultilineMethodCallIndentation: Align .github_repository with current_submission on line 96.
houndci-bot
reviewed
Jul 18, 2018
| .github_repository | ||
| .present?(headers: GitHub::APIHeaders.no_cache_no_store) | ||
| .github_repository | ||
| .present?(headers: GitHub::APIHeaders.no_cache_no_store) |
There was a problem hiding this comment.
Layout/MultilineMethodCallIndentation: Align .present? with current_submission on line 96.
| @@ -94,13 +94,17 @@ def join_roster | |||
| def ensure_submission_repository_exists | |||
| return not_found unless current_submission | |||
| return if current_submission | |||
| .github_repository | |||
| .present?(headers: GitHub::APIHeaders.no_cache_no_store) | |||
| .github_repository | |||
There was a problem hiding this comment.
Layout/MultilineMethodCallIndentation: Align .github_repository with current_submission on line 96.
BenEmdon
changed the title
d12
approved these changes
Jul 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR changes the behavior in
ensure_submission_repository_existssuch that if anAssignmentRepois created it redirects to#setupv2when in theimport_resiliencybeta is enabled.How
This behavior was happening in a
before_action:https://github.com/education/classroom/blob/cd1d7e63bd6dada2f7f76a79d7c447147c9ac8f1/app/controllers/assignment_invitations_controller.rb#L8
Didn't catch this when I made the original change in #1385