-
Notifications
You must be signed in to change notification settings - Fork 5k
Add Vim9 Script #7763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Vim9 Script #7763
Conversation
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test failures indicate you've not followed the instructions in the CONTRIBUTING.md file for adding a language and grammar. Please do so.
While there are not 100+ repos using vim9script I believe a large reason for the lack of adoption is the lack of syntax highlighting support that makes some of our efforts to use modern vimscript harder for new plugin writers.
I can't help but feel this PR is a very premature. You're barely over 100 .vim files which is a long way from our requirements (see the issue linked in the CONTRIBUTING.md file) and there are only 2 .vim9 files. All extensions must meet our usage requirements before a PR can be merged.
|
@lildude RE popularity; I'm wondering if the search feature isn't working correctly since the results don't show a single one of my own plugins or files that are written in vim9 script. I also don't see many plugins that are a part of the awesome-vim9 list (77 repos on that list alone which doesnt match the Repo count shown either). Very possible I messed up the query last night when opening the PR To add additional context for my thinking on search being broken. I have a repo https://github.com/DanBradbury/copilot-chat.vim that is not a fork and includes vim9 script files in the default branch.. however with the default search none of my files show up in the query. If I add an additional param to include the repo itself then I get 11 file results (see https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.vim+vim9script+repo%3ADanBradbury%2Fcopilot-chat.vim+) When doing a cursory look on the files pulled up I'm not seeing a lot of repos from awesome-vim9 that I know are valid vim9 script plugins that are not forks. The reason I'm so familiar with these repos is because of my work on a vim9 linter where I test against these repos (https://github.com/DanBradbury/vinter/blob/main/vinter_report.md) |
|
@lildude - I tried my best to address your comments + include another |
Adds vim9 script as a new language.
Description
Since the syntax is quite different from legacy vimscript I've added this as a new language and added a heuristic since all vim9 script files must start with
vim9scripton the first line. This allows for clear detection of vim and vim9script within reposWhile there are not 100+ repos using vim9script I believe a large reason for the lack of adoption is the lack of syntax highlighting support that makes some of our efforts to use modern vimscript harder for new plugin writers.
Checklist:
#007030