Skip to content

Add ESLint dependencies and configuration updates #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DawidRyczko
Copy link

The pull request fixes the problem with failing test when following the steps here: https://resources.github.com/learn/pathways/automation/essentials/application-testing-with-github-actions/

We can't run the test command because missing configuration for Eslint:
image

There is also a problem with no-unescaped-entities and failing linter:
image

Not sure where I can raise the problem, but the step is also failing:
https://resources.github.com/learn/pathways/automation/essentials/automating-deploying-workflows-with-github-actions/
The instruction should be updated because the actions/upload-pages-artifact@v1 and actions/deploy-pages@v1are deprecated. The actions should be updated to actions/upload-pages-artifact@v3 and actions/deploy-pages@v4

@Arnold-P-Murphy
Copy link

I am new to this, how can I make these changes ?

@DawidRyczko
Copy link
Author

I am new to this, how can I make these changes ?

You can use my branch or clone the main branch run npm install and run lint, and you can follow the step in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants