Skip to content

move use of input variables into env vars #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Conversation

nickfyson
Copy link
Contributor

@nickfyson nickfyson commented Apr 9, 2025

This PR moves a number of uses of ${{ inputs.foo_bar }} into environment variables for the step in question.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@Copilot Copilot bot review requested due to automatic review settings April 9, 2025 13:14
@nickfyson nickfyson requested a review from a team as a code owner April 9, 2025 13:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors GitHub Actions workflows by moving direct input variable usage into environment variables for improved readability and maintainability.

  • In the release-branches action, inputs for "major_version" and "latest_tag" are now set as environment variables.
  • In the prepare-test action, inputs for "version" and "use-all-platform-bundle" are similarly moved into environment variables and used in conditional checks.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/actions/release-branches/action.yml Introduces env vars for MAJOR_VERSION and LATEST_TAG, and updates command args
.github/actions/prepare-test/action.yml Adds env vars for VERSION and USE_ALL_PLATFORM_BUNDLE, and updates comparison logic

@nickfyson nickfyson merged commit c7dbb20 into main Apr 9, 2025
270 checks passed
@nickfyson nickfyson deleted the nickfyson/address-vulns branch April 9, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants