Skip to content

Notify waiting channels on completed transaction, not just the watermark #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2025

Conversation

misalcedo
Copy link

Description

This PR extends #1454 to notify waiting transactions not just when the watermark increases, but also when the transaction is completed.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@misalcedo misalcedo marked this pull request as ready for review April 10, 2025 15:32
@Copilot Copilot AI review requested due to automatic review settings April 10, 2025 15:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that waiting transactions are notified not only when the watermark increases but also when a transaction is completed. Key changes include:

  • Extending the notification logic in coordinator.go to trigger on transaction completion.
  • Updating the test suite in coordinator_test.go to simulate concurrent transactions using errgroup and randomize the number of inserts per transaction.
  • Configuring additional connection limits in the test setup to support increased concurrency.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

File Description
go/logic/coordinator_test.go Updated test logic for concurrent transaction simulation and setup.
go/logic/coordinator.go Modified notification logic to include transaction completion conditions.

@meiji163 meiji163 merged commit b23d20f into meiji163/parallel-repl Apr 10, 2025
6 checks passed
@misalcedo misalcedo deleted the misalcedo/parallel branch April 10, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants