Skip to content

Bump go-github to v73.0.0 #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

martinnormark
Copy link

Decided to make this upgrade in separate PR, instead of mixing with #470

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 08:04
@martinnormark martinnormark requested a review from a team as a code owner June 27, 2025 08:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the go-github module from v72 to v73 across the codebase, updates third-party license documents accordingly, and adds the new dependency to go.mod.

  • Bump all github.com/google/go-github/v72/github imports to v73
  • Update third-party license entries for the new v73 dependency
  • Add github.com/google/go-github/v73 v73.0.0 to go.mod

Reviewed Changes

Copilot reviewed 33 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
third-party-licenses.windows.md Replace v72 license entry with v73
third-party-licenses.linux.md Replace v72 license entry with v73
third-party-licenses.darwin.md Replace v72 license entry with v73
pkg/raw/raw_test.go Update import path for go-github to v73
pkg/raw/raw.go Update import path for go-github to v73
pkg/github/tools.go Update import path for go-github to v73
pkg/github/server_test.go Update import path for go-github to v73
pkg/github/server.go Update import path for go-github to v73
pkg/github/secret_scanning_test.go Update import path for go-github to v73
pkg/github/secret_scanning.go Update import path for go-github to v73
pkg/github/search_utils.go Update import path for go-github to v73
pkg/github/search_test.go Update import path for go-github to v73
pkg/github/search.go Update import path for go-github to v73
pkg/github/repository_resource_test.go Update import path for go-github to v73
pkg/github/repository_resource.go Update import path for go-github to v73
pkg/github/repositories_test.go Update import path for go-github to v73
pkg/github/repositories.go Update import path for go-github to v73
pkg/github/pullrequests_test.go Update import path for go-github to v73
pkg/github/pullrequests.go Update import path for go-github to v73
pkg/github/notifications_test.go Update import path for go-github to v73
pkg/github/notifications.go Update import path for go-github to v73
pkg/github/issues_test.go Update import path for go-github to v73
pkg/github/issues.go Update import path for go-github to v73
pkg/github/context_tools_test.go Update import path for go-github to v73
pkg/github/code_scanning_test.go Update import path for go-github to v73
pkg/github/code_scanning.go Update import path for go-github to v73
pkg/github/actions_test.go Update import path for go-github to v73
pkg/github/actions.go Update import path for go-github to v73
pkg/errors/error_test.go Update import path for go-github to v73
pkg/errors/error.go Update import path for go-github to v73
internal/ghmcp/server.go Update import alias for go-github to v73
go.mod Add github.com/google/go-github/v73 v73.0.0
e2e/e2e_test.go Update import alias for go-github to v73

@martinnormark
Copy link
Author

Noticing I did the same mistake as in #456 (comment) @williammartin - I tried to run it, and it removed all license files and cleared the third-party-license.*.md files. I am probably missing something when running it?

@williammartin
Copy link
Collaborator

I'd suggest resetting to your first commit and then running ./script/licenses. I would expect that will resolve things.

@martinnormark
Copy link
Author

Fixed in 978bfa9, it was a local problem with the go-licenses dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants