-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove redundant param for get_me and update contribution guide #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the now-unnecessary reason
parameter from the get_me
tool and updates related documentation and snapshots.
- Removed the
reason
field from the Go tool definition and its snapshot - Updated README to indicate no parameters are required
- Reformatted the CONTRIBUTING guide’s checklist for clarity
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
pkg/github/context_tools.go | Removed mcp.WithString("reason",…) calls in GetMe |
pkg/github/toolsnaps/get_me.snap | Cleared out the reason property in the snapshot |
README.md | Changed parameter list to “No parameters required” |
CONTRIBUTING.md | Converted hyphenated list to numbered steps and added detail |
Comments suppressed due to low confidence (2)
README.md:553
- [nitpick] Indent the "No parameters required" bullet under the
get_me
entry so it correctly nests as a sub-item in the markdown list.
- No parameters required
CONTRIBUTING.md:27
- [nitpick] Indent these hyphenated sub-steps under step 5 to ensure they render as nested list items in the markdown.
- Run linter: `script/lint`
CONTRIBUTING.md
Outdated
- Run linter: `script/lint` | ||
- Update snapshots and run tests: `UPDATE_TOOLSNAPS=true go test ./...` | ||
- Update readme documentation: `script/generate-docs` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: indent these so they appear as nested inside step 5
This pr:
reason
argument forget_me
tool call.