Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3297 - Adds default setting for compact graph #3300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TJohnsonSE
Copy link
Contributor

Description

I've added the requested feature (#3297) to have a configuration to default to the compact view in the Commit Graph. This feature adds a checkbox to the Gitlens settings page, a relevant configuration setting to the GraphConfig and GraphComponentConfig interfaces, and then the logic to actually implement defaulting to the compact graph view in the graphWebView component.

Testing indicated it's all working as expected.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@TJohnsonSE TJohnsonSE force-pushed the feature-3297/commit-graph-compact-view-by-default branch 3 times, most recently from 16647ce to 3fd26a3 Compare May 17, 2024 07:03
@TJohnsonSE TJohnsonSE changed the title Adds feature #3297 - Setting for compact graph Closes #3297 - Adds default setting for compact graph May 17, 2024
@TJohnsonSE TJohnsonSE force-pushed the feature-3297/commit-graph-compact-view-by-default branch 2 times, most recently from 542ecb7 to 789696d Compare May 19, 2024 15:55
@TJohnsonSE TJohnsonSE force-pushed the feature-3297/commit-graph-compact-view-by-default branch 4 times, most recently from 529f422 to 5bb3a16 Compare June 4, 2024 19:47
@eamodio
Copy link
Member

eamodio commented Jun 4, 2024

@TJohnsonSE Thanks for this! Unfortunately because this modifies files in the plus folders, we can't accept this PR directly without a Contributor License Agreement (CLA). And we don't currently have a CLA process in place yet.

So I can let this sit for a while until we work out that CLA process (though it will likely be a couple of months) -- or I can close this an implement the feature directly. Thoughts?

@TJohnsonSE
Copy link
Contributor Author

@eamodio of course, thanks for looking at this! That is unfortunate to hear, I did read the note before contributing but didn't pay attention to the directories.

If it's something you don't mind sitting on and revisiting later down the road, I'm okay with that. If it's a feature you just want to get in since it's already done, I'm also okay with the PR being closed and having you implement it directly.

I'll see where else I can focus in the meantime, and I appreciate the feedback.

@TJohnsonSE TJohnsonSE force-pushed the feature-3297/commit-graph-compact-view-by-default branch from 5bb3a16 to 8d72db3 Compare June 5, 2024 23:56
@TJohnsonSE TJohnsonSE force-pushed the feature-3297/commit-graph-compact-view-by-default branch from 82647a1 to 8d72db3 Compare June 16, 2024 17:38
@TJohnsonSE TJohnsonSE force-pushed the feature-3297/commit-graph-compact-view-by-default branch from 8d72db3 to fcc9a27 Compare June 16, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants