-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
build(deps): bump mastra from 0.13.4 to 0.18.6 #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
pnpm-lock.yaml
Outdated
| '@mastra/server': 0.24.6(@mastra/[email protected]([email protected])([email protected])([email protected]))([email protected]) | ||
| '@neon-rs/load': 0.1.82 | ||
| '@optimize-lodash/rollup-plugin': 5.0.2([email protected]) | ||
| '@optimize-lodash/rollup-plugin': 5.1.0([email protected]) | ||
| '@rollup/plugin-alias': 5.1.1([email protected]) | ||
| '@rollup/plugin-commonjs': 28.0.9([email protected]) | ||
| '@rollup/plugin-commonjs': 28.0.6([email protected]) | ||
| '@rollup/plugin-esm-shim': 0.1.8([email protected]) | ||
| '@rollup/plugin-json': 6.1.0([email protected]) | ||
| '@rollup/plugin-node-resolve': 16.0.3([email protected]) | ||
| '@rollup/plugin-node-resolve': 16.0.2([email protected]) | ||
| '@rollup/plugin-virtual': 3.0.2([email protected]) | ||
| '@sindresorhus/slugify': 2.2.1 | ||
| builtins: 5.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Backend will crash on startup due to missing @mastra/mcp dependency still being imported.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The backend server will crash immediately on startup because the @mastra/mcp dependency is missing from pnpm-lock.yaml but is still imported and used during application initialization. Specifically, startMcp calls import { MCPServer } from '@mastra/mcp', which will fail with Cannot find module '@mastra/mcp' as the package was removed during the Mastra dependency upgrade from 0.13.4 to 0.18.6. The startMcp call is not wrapped in a try-catch block, leading to an unhandled exception and application failure.
💡 Suggested Fix
Update code to use the new Mastra API, explicitly add @mastra/mcp back as a dependency, or remove/rewrite the startMcp function.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pnpm-lock.yaml#L20455-L20474
Potential issue: The backend server will crash immediately on startup because the
`@mastra/mcp` dependency is missing from `pnpm-lock.yaml` but is still imported and used
during application initialization. Specifically, `startMcp` calls `import { MCPServer }
from '@mastra/mcp'`, which will fail with `Cannot find module '@mastra/mcp'` as the
package was removed during the Mastra dependency upgrade from 0.13.4 to 0.18.6. The
`startMcp` call is not wrapped in a try-catch block, leading to an unhandled exception
and application failure.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 339077
1d2011b to
03ee7dc
Compare
03ee7dc to
2a5734a
Compare
2a5734a to
4bfcda4
Compare
Bumps [mastra](https://github.com/mastra-ai/mastra/tree/HEAD/packages/cli) from 0.13.4 to 0.18.6. - [Release notes](https://github.com/mastra-ai/mastra/releases) - [Changelog](https://github.com/mastra-ai/mastra/blob/[email protected]/packages/cli/CHANGELOG.md) - [Commits](https://github.com/mastra-ai/mastra/commits/[email protected]/packages/cli) --- updated-dependencies: - dependency-name: mastra dependency-version: 0.18.6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
4bfcda4 to
dfddd1d
Compare
Bumps mastra from 0.13.4 to 0.18.6.
Release notes
Sourced from mastra's releases.
... (truncated)
Changelog
Sourced from mastra's changelog.
... (truncated)
Commits
7e6db67chore: version - exit prerelease mode5288877chore: version packages (alpha) (#10395)ccb7552fix: Rename remaining "Playground" to "Studio" (#10443) (#10467)e6f4eb5chore: version - exit prerelease mode492425achore: version packages (alpha) (#10374)1140159chore: version - exit prerelease modea4c9fd5chore: version packages (alpha) (#10367)57cdb8bchore: version - exit prerelease mode9638999chore: version packages (alpha) (#10295)4aeda60fix(create): detect package manager runtime and cleanup on failure (#10307)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)