fix(auth): fix public API middleware user role structure #1133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Why was this change needed?
The public API authentication middleware (
public.auth.middleware.ts) was setting an incorrect nested structure for the mock user role:// Before (incorrect)
req.org = { ...org, users: [{ users: { role: 'SUPERADMIN' } }] };// After (correct)
req.org = { ...org, users: [{ role: 'SUPERADMIN' }] };The permissions guard at
permissions.guard.ts:46accessesorg.users[0].roleto check user permissions. With the incorrect nested structure, this returnedundefinedinstead of'SUPERADMIN', causing@CheckPoliciesdecorated endpoints to fail whenSTRIPE_PUBLISHABLE_KEYis configured.This bug was masked in environments without Stripe because the permissions service automatically grants all permissions when
STRIPE_PUBLISHABLE_KEYis not set.The fix aligns the structure with what
getOrgsByUserIdreturns:users: [{ disabled, role }].Other information:
This was discovered while adding new public API endpoints for integration management. The existing public API endpoints with
@CheckPolicies(likePOST /public/v1/posts) were also affected by this bug in production environments with Stripe enabled.Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;