Feature/1164 #1165
Open
Feature/1164 #1165
+209
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DominikLudwiczak is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
DominikLudwiczak
temporarily deployed
to
build-pr
GitHub Actions
Inactive
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| import { AddTeamMemberDto } from '@gitroom/nestjs-libraries/dtos/settings/add.team.member.dto'; | ||
| import { ApiTags } from '@nestjs/swagger'; | ||
| import { AuthorizationActions, Sections } from '@gitroom/backend/services/auth/permissions/permission.exception.class'; | ||
| import { User } from 'facebook-nodejs-business-sdk'; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Author
There was a problem hiding this comment.
right, I pushed change
DominikLudwiczak
temporarily deployed
to
build-pr
GitHub Actions
Inactive
| @Body() body: ChangePasswordDto | ||
| ) { | ||
| const userWithPassword = await this._userService.getUserById(user.id); | ||
| if(!userWithPassword || !AuthChecker.comparePassword(body.oldPassword, userWithPassword.password)) { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Author
There was a problem hiding this comment.
right, changed it and also in setting tab on frontend part I added condition that only LOCAL users can see change password tab
DominikLudwiczak
temporarily deployed
to
build-pr
GitHub Actions
Inactive
Comment on lines
60
to
64
| const userWithPassword = await this._userService.getUserById(user.id); | ||
| if(userWithPassword.providerName !== 'LOCAL') { | ||
| return false; | ||
| } | ||
| if(!userWithPassword || !AuthChecker.comparePassword(body.oldPassword, userWithPassword.password)) { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
DominikLudwiczak
temporarily deployed
to
build-pr
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
applies password change feature
Why was this change needed?
#1164
Other information:
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;