Skip to content

Conversation

@nevo-david
Copy link
Contributor

@nevo-david nevo-david commented Dec 9, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced media upload functionality for LinkedIn posts, allowing for better handling of image types and formats.
    • Added support for specifying media upload type (personal or company).
  • Bug Fixes

    • Improved error handling for media uploads, providing clearer feedback on posting errors.

@vercel
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
gitroom ⬜️ Ignored (Inspect) Dec 9, 2024 3:33pm
postiz ⬜️ Ignored (Inspect) Dec 9, 2024 3:33pm

@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in the LinkedinProvider class within the linkedin.provider.ts file focus on enhancing media upload functionalities and error handling. The uploadPicture method now accepts a new parameter, type, for specifying the media type. The image processing logic has been improved using the sharp library for resizing and format conversion. The post method has been updated to handle multiple media uploads concurrently, ensuring only valid media IDs are sent to LinkedIn. Additionally, error handling has been refined with the introduction of a BadBody exception.

Changes

File Path Change Summary
libraries/nestjs-libraries/src/integrations/social/linkedin.provider.ts - Updated uploadPicture method to include a new type parameter for media type.
- Enhanced image processing using sharp for JPEG conversion and resizing.
- Improved post method to handle concurrent media uploads with Promise.all and filter valid media IDs.
- Introduced BadBody exception for clearer error handling.

Poem

In the meadow where the code does play,
A rabbit hops with joy today.
Media uploads, swift and bright,
With sharp and JPEG, oh what a sight!
Errors now clearer, no more dismay,
Hooray for LinkedIn, hip-hip-hooray! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b17727b and c9e8914.

📒 Files selected for processing (1)
  • libraries/nestjs-libraries/src/integrations/social/linkedin.provider.ts (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nevo-david nevo-david merged commit 8966bf9 into main Dec 9, 2024
5 checks passed
naruki1024 pushed a commit to naruki1024/postiz-app that referenced this pull request Jan 10, 2025
…ehaviour

Weird behavior with LinkedIn not posting PNG even though it uploads them
@nevo-david nevo-david deleted the feat/linkedin-weird-behaviour branch January 26, 2025 10:04
@coderabbitai coderabbitai bot mentioned this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants