Open
Conversation
|
@tcarreira is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
1 task
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where alt text (image descriptions) for Mastodon posts were not being properly set. Previously, images were uploaded without their alt text being applied, resulting in "No Alt Text" appearing on posted images.
Key changes:
- Modified the
uploadFilemethod to return the complete media object instead of just the ID - Added a new
updateMediaDescriptionmethod to set alt text on uploaded media - Updated the post creation flow to apply alt text to media after upload
578b18b to
1960c98
Compare
Author
|
@egelhaus @nevo-david do you have any request/comment for this PR? |
b1da03c to
09f4274
Compare
|
I would really love to see this merged soon. Is there any ETA? |
|
I just tested this PR and it works well: https://gruene.social/@weddige/116070479038422126 |
Author
|
@egelhaus @nevo-david |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix or Feature, depends on the perspective 😃
Why was this change needed?
Fixing alt text for Mastodon posts
Fixes #948
Tested on my postiz server. It works on my machine 😁
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;