Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check cargo sort in make check #2572

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Check cargo sort in make check #2572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
* Select syntax highlighting theme out of the defaults from syntect [[@vasilismanol](https://github.com/vasilismanol)] ([#1931](https://github.com/extrawurst/gitui/issues/1931))
* new command-line option to override the default log file path (`--logfile`) [[@acuteenvy](https://github.com/acuteenvy)] ([#2539](https://github.com/gitui-org/gitui/pull/2539))
* dx: `make check` checks Cargo.toml dependency ordering using `cargo sort` [[@naseschwarz](https://github.com/naseschwarz)]

### Changed
* improve syntax highlighting file detection [[@acuteenvy](https://github.com/acuteenvy)] ([#2524](https://github.com/extrawurst/gitui/pull/2524))
Expand Down
7 changes: 5 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

.PHONY: debug build-release release-linux-musl test clippy clippy-pedantic install install-debug
.PHONY: debug build-release release-linux-musl test clippy clippy-pedantic install install-debug sort

ARGS=-l
# ARGS=-l -d ~/code/extern/kubernetes
Expand Down Expand Up @@ -94,7 +94,7 @@ clippy:
clippy-nightly:
cargo +nightly clippy --workspace --all-features

check: fmt clippy test deny
check: fmt clippy test deny sort

check-nightly:
cargo +nightly c
Expand All @@ -104,6 +104,9 @@ check-nightly:
deny:
cargo deny check

sort:
cargo sort -c -w "."

install:
cargo install --path "." --offline --locked

Expand Down
Loading