Skip to content

Fix #315 run brew test in CI #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

peso
Copy link
Contributor

@peso peso commented Apr 7, 2025

This Pull Request fixes/closes #315 .

It changes the following:

  • CI script has a new job that build gitui from source at head, using brew, and runs brew test

I followed the checklist:

  • [no] I added unittests
  • [no] I ran make check without errors
  • [no] I tested the overall application
  • [no] I added an appropriate item to the changelog

..but, I did make a custom tap of brew, introduced an error in the source code on my fork and let my custom brew discover it.

The thing is, there is no change to the source code of gitui, only to the CI script. The change looks at gitui main branch head, which I cannot touch - so I had to hack around to fake a test. I have demonstrated that it works on my fork, but not that it works on gitui master branch.

@extrawurst
Copy link
Collaborator

@peso thanks for looking into this. any idea why this checks out 0.7.0? see https://github.com/gitui-org/gitui/actions/runs/14307675619/job/40103031807?pr=2596#step:8:42

@peso
Copy link
Contributor Author

peso commented Apr 7, 2025

The gitui 0.7.0 puzzled me as well, but it is simply test data for the brew ui test.
The brew test clones the repository at that commit, opens it with gitui, and expects to see the author of the commit on the screen.
It could have been any commit in any repository, as long as the test was updated to reflect what was in the commit.

@extrawurst
Copy link
Collaborator

@peso thank you!

@extrawurst extrawurst merged commit 313220a into gitui-org:master Apr 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add brew validate to CI
2 participants