Skip to content

implement remainder operation for Fixed type and add corresponding tests #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 29, 2025

Conversation

MahmoudMohajer
Copy link
Contributor

These changes introduce the Reminder operator to NumerAir, ensuring its seamless integration into the system. Additionally, comprehensive tests have been implemented to validate its functionality and expected behavior. These tests confirm that the operator performs correctly across various scenarios, maintaining the integrity and reliability of NumerAir.

@raphaelDkhn
Copy link
Contributor

Thanks @MahmoudMohajer for the PR.

  • Can you add tests with random values as well, as implemented for other ops.
  • The evaluation function (eval_fixed_rem) is missing. This will evaluate constraints for each rem operations during proving

@raphaelDkhn raphaelDkhn merged commit d92f59d into gizatechxyz:master May 29, 2025
@raphaelDkhn
Copy link
Contributor

@all-contributors add @MahmoudMohajer for code

Copy link
Contributor

@raphaelDkhn

I've put up a pull request to add @MahmoudMohajer! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants