Fix: Export the Console Interface as ConsoleLike
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Totto16
force-pushed
the
fix_gnome_48_console
branch
2 times, most recently
from
76ddaf3 to
efcc2f8
Compare
swsnr
requested changes
Mar 23, 2025
swsnr
approved these changes
Mar 23, 2025
|
Sorry accidentally approved 😅 Didn't mean to, this needs at least one change to make it usable |
Totto16
force-pushed
the
fix_gnome_48_console
branch
from
d2856ed to
1752816
Compare
|
@swsnr should we / I make a new release, as you like to use this type? |
|
I already use the workaround we talked about in the other discussion, so this isn't blocking me, but having a proper type would certainly be nicer, so if it's not too much of an effort I'd appreciate a release 😇 |
|
@swsnr I made a GH and npm release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #61 (comment)
This is just a proposal on how to fix the problem from #61 (comment)
Type duplication is bad, but to convert the class approach one to one, it has to be done.
I don't think the class is necessary, as it is never really used as class, the constructor i not accessible, all members are private, so only member methods are usable, which make it, from a type perspective equal to an interface.
Edit: I found a way to avoid type duplication: see here