Skip to content

gh-406: array API support for glass.arraytools #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

gh-406: array API support for glass.arraytools #597

wants to merge 24 commits into from

Conversation

paddyroddy
Copy link
Member

Description

WIP

Closes: #406

Changelog entry

Changed: Made glass.arraytools Array API compliant

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@paddyroddy paddyroddy added enhancement New feature or request array-api Work is related to the Array API testing Work is related to testing labels Apr 4, 2025
@paddyroddy paddyroddy self-assigned this Apr 4, 2025
paddyroddy
paddyroddy commented Apr 4, 2025
View reviewed changes
This was referenced Apr 8, 2025
Closed
Merged
Saransh-cpp
Saransh-cpp reviewed Apr 11, 2025
View reviewed changes
@paddyroddy paddyroddy mentioned this pull request Apr 30, 2025
Closed
@paddyroddy paddyroddy changed the base branch from main to paddy/issue-612 April 30, 2025 16:11
@paddyroddy paddyroddy mentioned this pull request May 7, 2025
Merged
5 tasks
Base automatically changed from paddy/issue-612 to main May 7, 2025 10:11
@paddyroddy paddyroddy mentioned this pull request May 22, 2025
Open
paddyroddy
paddyroddy commented May 30, 2025
View reviewed changes
pyproject.toml
@@ -23,6 +23,7 @@ dependencies = [
"cosmology.api>=0.3.2",
"healpix>=2022.11.1",
"healpy>=1.15.0",
"jaxtyping>=0.3.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing this dependence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saransh-cpp Saransh-cpp Saransh-cpp left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@paddyroddy paddyroddy

Labels
array-api Work is related to the Array API enhancement New feature or request testing Work is related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array API: port straightforward functions in arraytools
2 participants
@paddyroddy @Saransh-cpp