gh-502: add array API tests and typing for grf._transformations
#614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saransh-cpp
added
typing
Saransh-cpp
force-pushed
the
saransh/array-api-tests-grf
branch
from
066c47f to
cdda0e6
Compare
Saransh-cpp
force-pushed
the
saransh/array-api-tests-grf
branch
from
cdda0e6 to
9d88886
Compare
paddyroddy
approved these changes
May 30, 2025
Comment on lines
-86
to
+95
| np.testing.assert_array_almost_equal_nulp(glass.grf.icorr(t1, t2, y), x, nulp=5) | ||
| np.testing.assert_array_almost_equal_nulp(glass.grf.icorr(t1, t2, y), x, nulp=8) |
There was a problem hiding this comment.
Any idea why this has changed?
There was a problem hiding this comment.
I get this with JAX with anything less than 8 -
============================================================================== FAILURES ===============================================================================
__________________________________________________________________ test_sqnormal_sqnormal[jax.numpy] __________________________________________________________________
xp = <module 'jax.numpy' from '/Users/saransh/Code/UCL/glass/.env/lib/python3.13/site-packages/jax/numpy/__init__.py'>
urng = <glass.jax.Generator object at 0x111a3ffd0>
def test_sqnormal_sqnormal(xp: types.ModuleType, urng: UnifiedGenerator) -> None:
lam1, var1 = urng.uniform(size=2)
a1 = xp.sqrt(1 - var1)
t1 = glass.grf.SquaredNormal(a1, lam1)
lam2, var2 = urng.uniform(size=2)
a2 = xp.sqrt(1 - var2)
t2 = glass.grf.SquaredNormal(a2, lam2)
# https://arxiv.org/pdf/2408.16903, (E.7)
x = urng.random(10)
y = 2 * lam1 * lam2 * x * (x + 2 * a1 * a2)
dy = 4 * lam1 * lam2 * (x + a1 * a2)
np.testing.assert_array_equal(glass.grf.corr(t1, t2, x), y)
> np.testing.assert_array_almost_equal_nulp(glass.grf.icorr(t1, t2, y), x, nulp=5)
E AssertionError: Arrays are not equal to 5 ULP (max is 8)
tests/grf/test_transformations.py:95: AssertionErrorThere was a problem hiding this comment.
Okay makes sense. Bit annoying.
Co-authored-by: Patrick J. Roddy <[email protected]>
|
I'm going to merge this just so we have fewer stale PRs when we resume work in September |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add array API tests and typing for
grf._transformations. Should be okay to merge after #610.Fixes: #502
Checks