pre-commit.ci: update pre-commit hooks #628
Conversation
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.12 → v0.12.2](astral-sh/ruff-pre-commit@v0.11.12...v0.12.2) - [github.com/rbubley/mirrors-prettier: v3.5.3 → v3.6.2](rbubley/mirrors-prettier@v3.5.3...v3.6.2) - [github.com/pre-commit/mirrors-mypy: v1.16.0 → v1.16.1](pre-commit/mirrors-mypy@v1.16.0...v1.16.1)
| cov_method: Callable[..., NDArray[Any]] | ||
| if method == "clip": | ||
| from glass.algorithm import cov_clip as cov_method | ||
| from glass.algorithm import cov_clip as cov_method # noqa: PLC0415 | ||
| elif method == "nearest": | ||
| from glass.algorithm import cov_nearest as cov_method | ||
| from glass.algorithm import cov_nearest as cov_method # noqa: PLC0415 | ||
| else: | ||
| msg = f"unknown method '{method}'" # type: ignore[unreachable] | ||
| raise ValueError(msg) |
There was a problem hiding this comment.
I think this needs a re-write
|
Let's disable |
I'll do it |
|
Raised #629 for the failing tests 😞 |
| hooks: | ||
| - id: ruff |
| @@ -135,6 +135,7 @@ xfail_strict = true | |||
| [tool.ruff] | |||
| fix = true | |||
| force-exclude = true | |||
| per-file-target-version = {"examples/*" = "py313"} | |||
There was a problem hiding this comment.
Found this new setting in the blog https://astral.sh/blog/ruff-v0.12.0#version-related-syntax-errors
There was a problem hiding this comment.
That's really useful! Good spot!
I turned it off for tests, not the main code — hesitant to do so. Besides the |
updates: