Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Matomo): put matomo into maintenance mode (#490) #492

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Anefu
Copy link
Contributor

@Anefu Anefu commented Jan 3, 2024

Pull Request Template

Proposed Changes

Description

This PR adds flags for disabling Matomo, prior to an upgrade (ref: https://matomo.org/faq/how-to/faq_111/)

Related Issues

Screenshots (if applicable)

Please provide screenshots or GIFs that demonstrate the changes if your pull request includes visual updates.

Checklist

  • I have read and followed the contributing guidelines for this repository.
  • My code follows the coding style and standards of this project.
  • I have tested my changes locally.
  • I have added or updated necessary documentation (if applicable).
  • All new and existing tests passed.
  • My changes have been reviewed by at least one other contributor.
  • I have updated the README or relevant documentation (if applicable).
  • I have added proper labels to this PR (e.g., bug, enhancement, documentation, etc.).

Copy link
Member

@pmig pmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution this will put Matomo into maintenance mode, but will not disable the maintenance mode after the upgrade was executed.

We need to also to adapt the install.sh file to disable the maintenance mode after plugins have been configured.

@Anefu
Copy link
Contributor Author

Anefu commented Jan 3, 2024

Thanks for your contribution this will put Matomo into maintenance mode, but will not disable the maintenance mode after the upgrade was executed.

We need to also to adapt the install.sh file to disable the maintenance mode after plugins have been configured.

I added a sed command to remove the lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put Matomo into maintenance mode before upgrading
2 participants