Skip to content

Conversation

@caiopo
Copy link
Contributor

@caiopo caiopo commented Nov 23, 2024

Adds bindings for Erlang's portable hashing function phash2.

I'm not super happy with the name hash_range, but I couldn't think of anything better...

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I've left a note inline.

Could you update the changelog also please.

@caiopo
Copy link
Contributor Author

caiopo commented Nov 26, 2024

Done, thanks!

Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lpil lpil merged commit dfab815 into gleam-lang:main Nov 27, 2024
1 check passed
@lpil
Copy link
Member

lpil commented Feb 13, 2025

Hi @caiopo! What were you using this function for? I'm doing some research to figure out improvements for this package.

@caiopo
Copy link
Contributor Author

caiopo commented Feb 14, 2025

Hi @lpil!
I was planning to develop a bloom filter library in Gleam. Inspired by a similar package made in Elixir.
It uses phash2 as its hash function, so it supports adding any term to the filter.

@lpil
Copy link
Member

lpil commented Feb 14, 2025

Great, thank you.

I'm refocusing this package on types and functions that most Erlang based programs will use, which means I'll be removing these functions sue to their being niche in use. The code is good so you could publish a package for them if you wish, otherwise you can copy them into your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants