Adapt range cell rendering based on the configured font size #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
changed the title
lukasmasuch
changed the title
lukasmasuch
changed the title
lukasmasuch
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the range cell rendering to dynamically size its label and bar based on the configured font size rather than using fixed pixel values.
- Exposes
getEmHeightfrom core to measure font heights. - Replaces static
12pxfont and6pxbar height with computedlabelFontandrangeHeightbased ontheme.baseFontStyle. - Applies dynamic sizing in
range-cell.tsxfor both drawing and text placement.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/core/src/index.ts | Exported getEmHeight to allow measuring font height. |
| packages/cells/src/cells/range-cell.tsx | Replaced static sizing with computed labelFont, emHeight, and rangeHeight. Removed RANGE_HEIGHT constant. |
BrianHung
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the range cell rendering to be adapted based on the configured font. Instead of a static
12pxfont size and6pxrange height, we take 90% of the configure font size for the range label and use 50% of the font (em) height for the range visualization. This makes the range cell better adapted to the configured theme.