Fixed messageFormat dependency omission and a timezone-dependent test#46
Open
MickeyPhoenix wants to merge 1 commit intoglobalizejs:masterfrom
Open
Conversation
@MickeyPhoenix since you own the GitHub fork, you should be able to grant him whatever permission he needs. |
octogonz
added a commit
to HBOCodeLabs/globalize-compiler
that referenced
this pull request
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A DEPENDENCY_VARS dependency on
messageFormat(bymessageFormatter) was accidentally deleted by #42.This PR restores that dependency, fixing #45.
We also identified (by virtue of being in PST) a timezone-dependent test, and have replaced it with an enhanced, timezone-independent test.
This PR was co-authored by @dharrie-hbo, but I don't seem to have permissions to add him. Could you please add him as co-author to this PR? Thanks!