Copy progress from #749 (cibuildwheel for Windows) #1340
Conversation
|
Thanks for working on this! |
|
It appears that the build succeeded! Could you please download the artifact, install it, and confirm that it works on your system. |
|
I tested the repaired wheel for python 3.9 and it passed all the tests. I reverted the changes to the CI so now it makes the tests for all versions. |
|
Strike that. It was a bug in the new beta GitHub pull request view that was not showing me all the changes. |
|
|
||
| # Install a modern version of CMake for compatibility with modern Visual Studio | ||
| pip install cmake | ||
| pip install "cmake<3.31.3" |
There was a problem hiding this comment.
Why can we not use the latest version?
| pip install "cmake<3.31.3" | |
| pip install "cmake==4.0.3" |
There was a problem hiding this comment.
The TBB build was failing with 4.0.3 even though it said that the minimun was 3.5:
+ powershell .github/workflows/cibuildwheel-before-build.ps1 D:\a\freud\freud
Collecting cmake
Downloading cmake-4.0.3-py3-none-win_amd64.whl.metadata (6.3 kB)
Downloading cmake-4.0.3-py3-none-win_amd64.whl (36.9 MB)
---------------------------------------- 36.9/36.9 MB 55.9 MB/s eta 0:00:00
Installing collected packages: cmake
Successfully installed cmake-4.0.3
Directory: D:\a\freud\freud\tbb
Mode LastWriteTime Length Name
---- ------------- ------ ----
d----- 7/10/2025 1:07 PM build
-- Building for: Visual Studio 17 2022
CMake Error at CMakeLists.txt:15 (cmake_minimum_required):
Compatibility with CMake < 3.5 has been removed from CMake.
I don't know if this is a know bug but I tried and it worked.
There was a problem hiding this comment.
Remove this file. It is not used as no CIBW_BEFORE_TEST_ configuration is set.
There was a problem hiding this comment.
Remove this file. It is not used as no CIBW_BEFORE_TEST_ configuration is set.
| pip install delvewheel | ||
|
|
||
| # From https://cibuildwheel.pypa.io/en/stable/options/#repair-wheel-command | ||
| delvewheel repair --add-path "C:/Program Files (x86)/TBB/bin/" -w "${DEST_DIR}" "${WHEEL}" |
There was a problem hiding this comment.
Why do these libraries appear in the x86 (32-bit) installation location? Do these scripts incorrectly build 32-bit binaries?
Description
Trying to make the wheels for Windows using the progress made in #749
Motivation and Context
delvewheel has improved over the four year this was lasty tried so want to see if it possible now.
Resolves: #1336
How Has This Been Tested?
Renabling the CI test for building Windows while disabling the ones in mac and ubuntu for the moment.
Checklist: