Skip to content

Update setup.py #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update setup.py #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions folly/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@
from Cython.Compiler import Options
from setuptools import Extension, setup

additional_libs = []
if sys.platform == 'darwin' and platform.machine() == 'arm64':
# Macos (arm64, homebrew path is different than intel)
library_dirs = ['/opt/homebrew/lib']
else:
# Debian/Ubuntu
library_dirs = ['/usr/lib', '/usr/lib/x86_64-linux-gnu']
additional_libs.extend(['unwind'])

# Add (prepend) library paths from CMAKE_PREFIX_PATH
if cmake_prefix_path := os.environ.get('CMAKE_PREFIX_PATH'):
Expand Down Expand Up @@ -56,7 +58,7 @@
'folly/ProactorExecutor.cpp',
'folly/error.cpp',
],
libraries=['folly', 'unwind', 'glog', 'double-conversion','fmt'],
libraries=['folly', 'glog', 'double-conversion','fmt'] + additional_libs,
extra_compile_args=['-std=c++20'], # C++20 for coroutines
include_dirs=['.', '../..'], # cython generated code
library_dirs=library_dirs,
Expand All @@ -69,7 +71,7 @@
'folly/iobuf_ext.cpp',
'folly/error.cpp',
],
libraries=['folly', 'unwind', 'glog', 'double-conversion', 'fmt'],
libraries=['folly', 'glog', 'double-conversion', 'fmt'] + additional_libs,
extra_compile_args=['-std=c++20'], # C++20 for coroutines
include_dirs=['.', '../..'], # cython generated code
library_dirs=library_dirs,
Expand All @@ -81,8 +83,8 @@
'folly/fibers.cpp',
'folly/error.cpp',
],
libraries=['folly', 'unwind', 'boost_coroutine', 'boost_context',
'glog', 'double-conversion', 'fmt', 'event'],
libraries=['folly', 'boost_coroutine', 'boost_context',
'glog', 'double-conversion', 'fmt', 'event'] + additional_libs,
extra_compile_args=['-std=c++20'], # C++20 for coroutines
include_dirs=['.', '../..'], # cython generated code
library_dirs=library_dirs,
Expand All @@ -98,4 +100,4 @@
zip_safe=False,
package_data={'': ['*.pxd', '*.pyi', '*.h', '__init__.py']},
ext_modules=cythonize(exts, compiler_directives={'language_level': 3}),
)
)