support drop table and fix create template

gnehil · Oct 31, 2023 · a87085b · a87085b
1 parent dd00f05
commit a87085b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/...ector-doris/src/main/java/org/apache/seatunnel/connectors/doris/catalog/DorisCatalog.java b/...ector-doris/src/main/java/org/apache/seatunnel/connectors/doris/catalog/DorisCatalog.java
@@ -285,7 +285,12 @@ public void createTable(TablePath tablePath, CatalogTable table, boolean ignoreI
     @Override
     public void dropTable(TablePath tablePath, boolean ignoreIfNotExists)
             throws TableNotExistException, CatalogException {
-        throw new UnsupportedOperationException();
+        String query = DorisCatalogUtil.getDropTableQuery(tablePath, ignoreIfNotExists);
+        try (Statement stmt = conn.createStatement()) {
+            stmt.execute(query);
+        } catch (SQLException e) {
+            throw new CatalogException(e);
+        }
     }
 
     @Override

diff --git a/...nector-doris/src/main/java/org/apache/seatunnel/connectors/doris/config/DorisOptions.java b/...nector-doris/src/main/java/org/apache/seatunnel/connectors/doris/config/DorisOptions.java
@@ -230,8 +230,8 @@ public interface DorisOptions {
                             "CREATE TABLE IF NOT EXISTS `${database}`.`${table_name}` (\n"
                                     + "${rowtype_fields}\n"
                                     + ") ENGINE=OLAP\n"
-                                    + " PRIMARY KEY (${rowtype_primary_key})\n"
-                                    + "DISTRIBUTED BY HASH (${rowtype_primary_key})"
+                                    + "UNIQUE KEY (${rowtype_primary_key})\n"
+                                    + "DISTRIBUTED BY HASH (${rowtype_primary_key})\n"
                                     + "PROPERTIES (\n"
                                     + "    \"replication_num\" = \"1\" \n"
                                     + ")")

diff --git a/...ctor-doris/src/main/java/org/apache/seatunnel/connectors/doris/util/DorisCatalogUtil.java b/...ctor-doris/src/main/java/org/apache/seatunnel/connectors/doris/util/DorisCatalogUtil.java
@@ -87,6 +87,10 @@ public static String getDropDatabaseQuery(String database, boolean ignoreIfNotEx
         return "DROP DATABASE " + (ignoreIfNotExists ? "IF EXISTS " : "") + database;
     }
 
+    public static String getDropTableQuery(TablePath tablePath, boolean ignoreIfNotExists) {
+        return "DROP TABLE " + (ignoreIfNotExists ? "IF EXISTS " : "") + tablePath.getFullName();
+    }
+
     /**
      * @param createTableTemplate create table template
      * @param catalogTable catalog table