Update code for breaking change in werkzeug #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dbalagansky thanks a lot for finding this breaking change that was blocking the upgrade jobs! I've merged a pinning of werkzeug<3.0.0 on all stable branches to get CI on all branches working again and also Please rebase this on master and unpin werkzeug completely (we don't pin unless it's on stable branches usually). I also think we need to workaround supporting werkzeug<3.0.0 on master as well so you'd need to add a try-except for this case. Have a nice weekend! [1] #1356 |
This is the follow-up for PR #1356.
dbalagansky
changed the title
|
Thanks! |
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Nov 7, 2023
* Update python-aodhclient from branch 'master'
to 6dd743f31590ebb95b1acba5909d6bbabaa8df75
- Fix gate
Install gnocchi from master branch until the recent fixes
will be included in next release.
More info at:
gnocchixyz/gnocchi#1354
Change-Id: If5140dfb9d9b41d7f1044f653701bed5e33cab62
openstack-mirroring
pushed a commit
to openstack/python-aodhclient
that referenced
this pull request
Nov 7, 2023
Install gnocchi from master branch until the recent fixes will be included in next release. More info at: gnocchixyz/gnocchi#1354 Change-Id: If5140dfb9d9b41d7f1044f653701bed5e33cab62
|
Folks, can we backport that to stable/4.6 ? |
noonedeadpunk
pushed a commit
to noonedeadpunk/gnocchi
that referenced
this pull request
Mar 14, 2024
This is the follow-up for PR gnocchixyz#1356 Cherry-picked from gnocchixyz#1354
This was referenced Mar 14, 2024
|
@Mergifyio backport stable/4.6 |
|
@noonedeadpunk ^ I can look into backporting and release a new minor version with that |
✅ Backports have been created
|
tobias-urdin
added a commit
that referenced
this pull request
Mar 15, 2024
Update code for breaking change in werkzeug (backport #1354)
|
@noonedeadpunk 4.6.2 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_authorization_headerwas removed here: pallets/werkzeug@bafffa9.