Clean raw data metrics that do not receive measures #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelweingartner
force-pushed
the
clean-raw-data-metrics-that-do-not-receive-measures
branch
16 times, most recently
from
aa9e0ea to
bd1caee
Compare
chungg
reviewed
Jun 3, 2024
...indexer/alembic/versions/18fff4509e3e_create_column_for_truncate_inactive_metrics_process.py
Show resolved
Hide resolved
chungg
reviewed
Jun 3, 2024
|
Thanks @chungg for the review! I address the points you raised, and replied to some of the open questions. I am eager to see your feedback on them! Again, thanks for the support here! |
|
Thanks @chungg! Your support is much appreciated! |
chungg
previously approved these changes
Jun 19, 2024
rafaelweingartner
force-pushed
the
clean-raw-data-metrics-that-do-not-receive-measures
branch
2 times, most recently
from
d08a08f to
33f7331
Compare
|
@chungg now this patch seems to be fine. I also squashed all commits to avoid mixing up things, as the patch was depending on others. |
The truncating of the raw metrics data is only done when new measures are pushed. Therefore, if no new measures are pushed, and the archive policy is updated to reduce the back window, the raw data points for metrics that are not receiving new data points are never truncated. The goal of this PR is to propose a method to identify metrics that are in "inactive state", meaning, not receiving new data points, and execute their raw data points truncation when the archive policy backwindow is changed.
rafaelweingartner
force-pushed
the
clean-raw-data-metrics-that-do-not-receive-measures
branch
from
33f7331 to
ee6428b
Compare
pedro-martins
approved these changes
Jun 26, 2024
|
Thank you guys (@pedro-martins and @chungg) for your reviews! If you think that there is something else to be changed, let me know. |
|
Hello @chungg and @tobias-urdin can we merge this one. I have some time this week, and I would like to use this time to rebase the other patch as soon as this patch is merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The truncating of the raw metrics data is only done when new measures are pushed. Therefore, if no new measures are pushed, and the archive policy is updated to reduce the back window, the raw data points for metrics that are not receiving new data points are never truncated.
The goal of this PR is to propose a method to identify metrics that are in "inactive state", meaning, not receiving new data points, and execute their raw data points truncation when the archive policy backwindow is changed.