Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase original resource ID max length to 289 chars #1438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase original resource ID max length to 289 chars #1438

wants to merge 1 commit into from
+58 −6

Conversation

Callum027
Copy link
Contributor

Ceilometer formats Swift container resource IDs in the format <project ID>_<container name>, where the project ID is 32 characters and container names can be up to 256 characters long, resulting in a resource ID with max length 289 characters.

To accommodate this, expand the original_resource_id column to have a max length of 289 characters.

@Callum027
Copy link
Contributor Author

Requires #1437 for the build to pass.

Given that this involves a database migration, if you'd like to take the opportunity to make the max ID length longer (e.g. 512 characters) that can be done instead, but the minimum required length to fix the Ceilometer issue is 289 characters.

@Callum027 Callum027 mentioned this pull request Jan 16, 2025
Open
@Callum027
Copy link
Contributor Author

Tested in a dev environment.

(ansible) root@callumdickinson-dev-ops1:~# openstack metric resource list --type swift_account
+--------------------------------------+---------------+----------------------------------+---------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------+----------------------------------+--------------+-------------------------------------------------------------------+
| id                                   | type          | project_id                       | user_id | original_resource_id                                                                                                                                                                                                                                                                              | started_at                       | ended_at | revision_start                   | revision_end | creator                                                           |
+--------------------------------------+---------------+----------------------------------+---------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------+----------------------------------+--------------+-------------------------------------------------------------------+
| 968d3a04-1aba-541c-87c4-b6fc19506033 | swift_account | 6ecc49947d244b23906084151adb29f0 | None    | 6ecc49947d244b23906084151adb29f0_volumes_backup_1.example.com                                                                                                                                                                                                                                     | 2025-01-15T04:33:35.083211+00:00 | None     | 2025-01-15T04:33:35.083228+00:00 | None         | 605810b30eaa44579bac4227d81a4f10:7342c96be2584fcb882ffc8872ba1346 |
| 842c8915-318c-5a1c-afb3-797d6d96897f | swift_account | 1de2828a81f34002b7fd13c7acdf4d93 | None    | 1de2828a81f34002b7fd13c7acdf4d93_in.pressure.already.writing.call.spoken.carry.fish.honor.key.occasionally.dry.favorite.writer.trunk.above.essential.division.major.involved.disease.search.wagon.work.cloth.ability.earth.meant.related.elephant.tax.bad.mass.wrapped.bowl.cost.composition.luck | 2025-01-16T20:49:04.000547+00:00 | None     | 2025-01-16T20:49:04.000565+00:00 | None         | 605810b30eaa44579bac4227d81a4f10:7342c96be2584fcb882ffc8872ba1346 |
+--------------------------------------+---------------+----------------------------------+---------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------------------------------+----------+----------------------------------+--------------+-------------------------------------------------------------------+

@Callum027 Callum027 force-pushed the original-resource-id-length branch 4 times, most recently from b94028d to 5a76f22 Compare January 21, 2025 02:01
@Callum027
Increase original resource ID max length to 289 chars
a708655 
Ceilometer formats Swift container resource IDs in the format
`<project ID>_<container name>`, where the project ID is 32 characters
and container names can be up to 256 characters long, resulting in a
resource ID with max length 289 characters.

To accommodate this, expand the `original_resource_id` column
to have a max length of 289 characters.
@Callum027 Callum027 force-pushed the original-resource-id-length branch from 5a76f22 to a708655 Compare January 21, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Callum027