Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase string attribute max length to 256 chars #1439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Callum027
Copy link
Contributor

Increase the maximum supported length for string type resource attributes from 255 to 256 characters, to allow creating string attributes on resources that accept values of such length (e.g. Swift container names).

@Callum027
Copy link
Contributor Author

Requires #1437 for the build to pass.

No database migrations are required because this does not modify existing attributes. It only increases the maximum supported length for new string-type attributes to 256 characters.

@Callum027
Copy link
Contributor Author

Tested in a dev environment with a custom resource type.

(ansible) root@callumdickinson-dev-ops1:~# openstack metric resource-type show volume_backup
+-------------------------+-----------------------------------------------------------+
| Field                   | Value                                                     |
+-------------------------+-----------------------------------------------------------+
| attributes/container    | max_length=256, min_length=0, required=True, type=string  |
| attributes/display_name | max_length=255, min_length=0, required=True, type=string  |
| attributes/snapshot_id  | max_length=255, min_length=0, required=False, type=string |
| attributes/volume_id    | max_length=255, min_length=0, required=True, type=string  |
| name                    | volume_backup                                             |
| state                   | active                                                    |
+-------------------------+-----------------------------------------------------------+

@Callum027 Callum027 force-pushed the string-attribute-length branch 2 times, most recently from ce207a0 to 28522a5 Compare January 21, 2025 01:53
Increase the maximum supported length for string type
resource attributes from 255 to 256 characters, to allow
creating string attributes on resources that accept values
of such length (e.g. Swift container names).
@Callum027 Callum027 force-pushed the string-attribute-length branch from 28522a5 to b19b5f5 Compare January 21, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant