Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup makefile and lock gno dependencies #164

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Apr 25, 2024

This PR accomplishes the following:

  • Lock and set gno version by using a go.mod for consistency and continuous integration against main gno repository through Dependabot.
  • Cleans up and simplifies the Makefile.
  • Makes Makefile the entry point for all commands by incorporating yarn script commands into it.
  • Add CI check for generate command

@gfanton gfanton self-assigned this Apr 25, 2024
@gfanton gfanton requested a review from a team as a code owner April 25, 2024 20:22
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for gno-by-example ready!

Name Link
🔨 Latest commit 91a62de
🔍 Latest deploy log https://app.netlify.com/sites/gno-by-example/deploys/662f57d760e2d10008d7a29d
😎 Deploy Preview https://deploy-preview-164--gno-by-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gfanton gfanton force-pushed the chore/cleanup-makefile branch 5 times, most recently from 9c2d93a to dcae40b Compare April 25, 2024 21:30
@gfanton gfanton force-pushed the chore/cleanup-makefile branch from dcae40b to aa5949d Compare April 25, 2024 21:33
@gfanton gfanton requested a review from leohhhn April 25, 2024 21:37
Signed-off-by: gfanton <[email protected]>
@gfanton gfanton requested a review from zivkovicmilos April 26, 2024 08:38
uses: ./.github/workflows/test.yaml
generate:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused how we didn't have this CI before 🤦‍♂️

schedule:
interval: "daily"
target-branch: "main"
versioning-strategy: "lockfile-only"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,5 +1,13 @@
version: 2
updates:
- package-ecosystem: "gomod"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add dependabot groups?

@@ -1,5 +1,13 @@
version: 2
updates:
- package-ecosystem: "gomod"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how gno will be updated as a dependency, since we don't do releases yet 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know it was not working on pseudo-release, I will remove dependabot for now

Signed-off-by: gfanton <[email protected]>
@zivkovicmilos
Copy link
Member

@gfanton
Is this PR still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants