Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): hall of fame #2842

Open
wants to merge 85 commits into
base: master
Choose a base branch
from
Open

feat(examples): hall of fame #2842

wants to merge 85 commits into from

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Sep 24, 2024

Description

Depends on #2584 for avlpager

Introduces the r/demo/hof realm.

The Hall of Fame is an exhibition that holds items. Users can add their realms to the Hall of Fame by importing the Hall of Fame realm and calling hof.Register() from their init function.

The realm is moderated and the registrations be paused at will.

Screenshot 2024-10-07 at 20 09 43

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn self-assigned this Sep 24, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Sep 24, 2024
@leohhhn leohhhn linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.33%. Comparing base (81a88a2) to head (a43ccc1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2842    +/-   ##
========================================
  Coverage   63.33%   63.33%            
========================================
  Files         548      548            
  Lines       78646    78819   +173     
========================================
+ Hits        49807    49919   +112     
- Misses      25478    25520    +42     
- Partials     3361     3380    +19     
Flag Coverage Δ
contribs/gnodev 61.16% <ø> (+0.04%) ⬆️
contribs/gnofaucet 15.77% <ø> (+0.94%) ⬆️
gno.land 67.13% <ø> (-0.05%) ⬇️
gnovm 67.88% <ø> (ø)
tm2 62.40% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

examples/gno.land/r/gnoland/hof/rendering.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/hof/rendering.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/hof/hof.gno Outdated Show resolved Hide resolved
@leohhhn leohhhn requested a review from jaekwon as a code owner October 8, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

"home of fame", an hall of fame for homepages.
4 participants