Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ci): coverpkg=gno.land/... for txtar tests #3088

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moul
Copy link
Member

@moul moul commented Nov 7, 2024

Note: I'm uncertain about what will happen after the merge.

Fixes #3085
Addresses #3003

@moul moul self-assigned this Nov 7, 2024
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Nov 7, 2024
@moul moul changed the title dev/moul/fix 3085 test(ci): coverpkg=gno.land/... for txtar tests Nov 7, 2024
@moul moul marked this pull request as ready for review November 7, 2024 23:05
@gfanton
Copy link
Member

gfanton commented Nov 7, 2024

I tried something more generic in 9adfc59 (#3086); unfortunately, it seems to makes the gnovm tests timeout :(

There is a chance that this PR could work since it only applies to gno.land, but having this kind of different rules per module/package will make potential similar issues, like the one you had in #3003, harder to debug in the futur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: 📥 Inbox
Status: Triage
Development

Successfully merging this pull request may close these issues.

Make txtar and Codecov play nice (upload coverage)
2 participants