feat: add JJOptimist's Homepage realm to examples #3405

JJOptimist · 2024-12-25T12:05:16Z

This pull request adds a new realm example to the Gno examples repository—JJOptimist's Homepage.

The realm includes:

Personal introduction and contact information
Configuration management system
Owner controls
Tests for ownership and rendering

Gno2D2 · 2024-12-25T12:06:21Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: JJOptimist/gno)
Then
🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
Can be checked by

team core-contributors

leohhhn

Please check comments 🙏

Apart from that, if you want to merge something into the examples/ folder, it should provide some educational value about Gno to newcomers. Please, explore a bit more and see what interesting realms or packages you can use to make your home realm more unique, so that it can be merged into the monorepo.

If you do not want to do this, you can simply deploy persmissionlessly.

leohhhn · 2024-12-27T04:32:09Z

examples/gno.land/r/jjoptimist/config.gno

+)
+
+var (
+


Unnecessary newline

leohhhn · 2024-12-27T04:35:37Z

examples/gno.land/r/jjoptimist/config.gno

+)
+
+func init() {
+    owner = OWNER_ADDR


If you're defining this at top-level, you can simply initiate it where you declared it.

This is a bit of a blurry line in Gno, so bear with me- following Go standards, if you can declare+initialize something immediately, do so at top level; init should be reserved for "doing" things you cannot do at declaration+initialization.

leohhhn · 2024-12-27T04:36:07Z

examples/gno.land/r/jjoptimist/config.gno

+
+    OWNER_ADDR = std.Address("g16vfw3r7zuz43fhky3xfsuc2hdv9tnhvlkyn0nj")
+
+    owner std.Address


Why not use p/demo/ownable?

leohhhn · 2024-12-27T04:36:22Z

examples/gno.land/r/jjoptimist/config.gno

+func GetConfig() struct {
+    title       string
+    description string
+    github     string
+} {


Nit: I think there is no need to fold this line

leohhhn · 2024-12-27T04:37:03Z

examples/gno.land/r/jjoptimist/home_test.gno

+)
+
+func TestOwnership(t *testing.T) {
+


Random newline

leohhhn · 2025-01-09T20:45:51Z

Hey @JJOptimist, what's the status of this PR?

JJOptimist · 2025-01-09T23:50:50Z

Hey @JJOptimist, what's the status of this PR?

I fixed the things you pointed out and took your suggestion to use ownable. Ive been experimenting to make something creative/ worth the HoF, so i will push it all together soon

JJOptimist · 2025-01-10T15:31:05Z

I've updated the realm

Integrated p/demo/ownable for proper ownership management and access control
Added dynamic ASCII art gnome that changes based on block height
Moved files to home/ directory structure
Added proper tests for both ownership and configuration

The gnome's expression changes based on block height divisibility (by 2, 3, 5, or 7)

jefft0 · 2025-01-10T15:33:37Z

mykey_backup.armor

Should this file be removed?

Thanks for quick notice, removed it

leohhhn · 2025-01-10T15:33:55Z

mykey_backup.armor

Leftover file?

Yes leftover, forgot i added it

leohhhn · 2025-01-10T15:37:35Z

@JJOptimist

Generally, please take a look at comments and reply to them, even if they're outdated because you've changed the code completely.

feat: add JJOptimist's Homerealm

f76c480

github-actions bot assigned JJOptimist Dec 25, 2024

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 25, 2024

notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 26, 2024

leohhhn self-requested a review December 27, 2024 04:31

leohhhn requested changes Dec 27, 2024

View reviewed changes

Merge branch 'gnolang:master' into master

b755bc7

feat: added usage of ownable and art

d7fec48

jefft0 reviewed Jan 10, 2025

View reviewed changes

leohhhn reviewed Jan 10, 2025

View reviewed changes

chore: remove mykey_backup.armor

6746b48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add JJOptimist's Homepage realm to examples #3405

feat: add JJOptimist's Homepage realm to examples #3405

JJOptimist commented Dec 25, 2024

Gno2D2 commented Dec 25, 2024 •

edited

Loading

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Can be checked by

If

Can be checked by

leohhhn left a comment

leohhhn Dec 27, 2024

leohhhn Dec 27, 2024

leohhhn Dec 27, 2024

leohhhn Dec 27, 2024

leohhhn Dec 27, 2024

leohhhn commented Jan 9, 2025

JJOptimist commented Jan 9, 2025

JJOptimist commented Jan 10, 2025

jefft0 Jan 10, 2025

JJOptimist Jan 10, 2025

leohhhn Jan 10, 2025

JJOptimist Jan 10, 2025

leohhhn commented Jan 10, 2025


		OWNER_ADDR = std.Address("g16vfw3r7zuz43fhky3xfsuc2hdv9tnhvlkyn0nj")

		owner std.Address

		)

		var (

feat: add JJOptimist's Homepage realm to examples #3405

Are you sure you want to change the base?

feat: add JJOptimist's Homepage realm to examples #3405

Conversation

JJOptimist commented Dec 25, 2024

Gno2D2 commented Dec 25, 2024 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Can be checked by

If

Can be checked by

leohhhn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leohhhn commented Jan 9, 2025

JJOptimist commented Jan 9, 2025

JJOptimist commented Jan 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leohhhn commented Jan 10, 2025

Gno2D2 commented Dec 25, 2024 •

edited

Loading