Skip to content

Conversation

@jefft0
Copy link
Contributor

@jefft0 jefft0 commented May 13, 2025

PR #3931 updates vm/qdoc to flag which functions are crossing. Update the gnoweb help page to indicate crossing functions.

(This is a draft PR to show the proof of concept. We can change how it shows that the function is crossing.)

image

@Gno2D2
Copy link
Collaborator

Gno2D2 commented May 13, 2025

🛠 PR Checks Summary

🔴 Changes related to gnoweb must be reviewed by its codeowners

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Changes related to gnoweb must be reviewed by its codeowners
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: jefft0/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes related to gnoweb must be reviewed by its codeowners

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^gno.land/pkg/gnoweb/ (filename: gno.land/pkg/gnoweb/components/views/action.html)

Then

🔴 Requirement not satisfied
└── 🔴 Or
    ├── 🔴 Or
    │   ├── 🔴 And
    │   │   ├── 🔴 Pull request author is user: alexiscolin
    │   │   └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")
    │   └── 🔴 And
    │       ├── 🔴 Pull request author is user: gfanton
    │       └── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED")
    └── 🔴 And
        ├── 🟢 Not (🔴 Pull request author is user: alexiscolin)
        ├── 🟢 Not (🔴 Pull request author is user: gfanton)
        └── 🔴 Or
            ├── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED")
            └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least one of these user(s) reviewed the pull request: [jefft0 leohhhn n0izn0iz notJoon omarsy x1unix] (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🟢 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@thehowl
Copy link
Member

thehowl commented May 13, 2025

noice :)

FWIW, this shoudl actually be used to filter out what is listed in the help page: only crossing functions can be used with maketx call

@jefft0
Copy link
Contributor Author

jefft0 commented May 14, 2025

FWIW, this shoudl actually be used to filter out what is listed in the help page: only crossing functions can be used with maketx call

Interesting. If the help page only shows crossing functions, then maybe we don't need to show "crossing"?

@jefft0
Copy link
Contributor Author

jefft0 commented May 14, 2025

Other ideas from the dev call:

  • Show gnokey query for all functions. Also show gnokey maketx only for crossing functions
  • Button for gnoweb to actually run the query and display the result
  • Make the "copy" icon targeted to single commands
  • Separate the page into categories of functions (section for crossing, section for non-crossing, etc.)
  • ... and/or dropdown to filter for categories of functions

@thehowl
Copy link
Member

thehowl commented May 15, 2025

cc @alexiscolin for potential design considerations

@github-actions github-actions bot added the 🌍 gnoweb Issues & PRs related to gnoweb and render label Aug 7, 2025
@jefft0 jefft0 force-pushed the chore/gnoweb-help-crossing branch from 061e03c to 3b33525 Compare August 7, 2025 13:42
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jefft0 jefft0 changed the title chore: In the gnoweb help page, flag crossing functions chore: In gnoweb help, flag crossing functions Aug 20, 2025
@jefft0 jefft0 force-pushed the chore/gnoweb-help-crossing branch from c24fac1 to 8404ef1 Compare October 6, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌍 gnoweb Issues & PRs related to gnoweb and render 📦 ⛰️ gno.land Issues or PRs gno.land package related

Projects

Status: No status
Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants