-
Notifications
You must be signed in to change notification settings - Fork 442
chore: In gnoweb help, flag crossing functions #4273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks Summary🔴 Changes related to gnoweb must be reviewed by its codeowners Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
|
noice :) FWIW, this shoudl actually be used to filter out what is listed in the help page: only crossing functions can be used with |
Interesting. If the help page only shows crossing functions, then maybe we don't need to show "crossing"? |
|
Other ideas from the dev call:
|
|
cc @alexiscolin for potential design considerations |
061e03c to
3b33525
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Jeff Thompson <[email protected]>
c24fac1 to
8404ef1
Compare
PR #3931 updates vm/qdoc to flag which functions are crossing. Update the gnoweb help page to indicate crossing functions.
(This is a draft PR to show the proof of concept. We can change how it shows that the function is crossing.)