Skip to content

Conversation

@moul
Copy link
Member

@moul moul commented Jun 13, 2025

examples/no_cycles_test.go was introduced in #3304, and we still want to keep it.
However, it creates an issue because the examples folder contains code that is not an example, which is not user-friendly.
Additionally, I believe it is currently not tested by the CI.

I suggest moving it to gno.land/pkg/gnoland, as I think that would be a suitable location, but I am open to other suggestions.

Depending on #4351, we may need to patch this test file to ignore stdlib.

cc @n0izn0iz @thehowl

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jun 13, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul moul requested review from n0izn0iz and thehowl June 13, 2025 14:39
@moul moul marked this pull request as ready for review June 13, 2025 14:39
@thehowl
Copy link
Member

thehowl commented Jun 27, 2025

The move looks good, but the test doesn't work. Maybe @n0izn0iz could make a PR fixing it up as well?

@n0izn0iz
Copy link
Contributor

@thehowl @moul I updated the test in this branch #4439
Couldn't open a PR against moul's fork so had to open it against gnolang's

@thehowl
Copy link
Member

thehowl commented Jun 30, 2025

merged #4439 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 ⛰️ gno.land Issues or PRs gno.land package related

Projects

Status: Done
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants