Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert PR 25: Remove the debugNow hack #143

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jefft0
Copy link
Contributor

@jefft0 jefft0 commented Nov 27, 2024

PR #25 added a "hack" function debugNow to solve the problem with "timestamps on reload". Now, PR gnolang/gno#2943 has been merged to fix it. This PR reverts to remove debugNow and restore time.Now .

@jefft0 jefft0 requested a review from D4ryl00 November 27, 2024 12:00
Copy link
Contributor

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefft0
Copy link
Contributor Author

jefft0 commented Nov 29, 2024

Waiting to merge until the weird date bug is fixed on portal loop.
https://gno.land/r/demo/boards:manfred/1
image

@jefft0
Copy link
Contributor Author

jefft0 commented Dec 9, 2024

Waiting on the merge of gnolang/gno#3308 which should fix the Portal Loop.

@jefft0
Copy link
Contributor Author

jefft0 commented Dec 9, 2024

PR gnolang/gno#3308 is merged and the Portal Loop works. Merging.

@jefft0 jefft0 merged commit 76fdc09 into gnoverse:main Dec 9, 2024
1 check passed
@jefft0 jefft0 deleted the chore/revert-PR-25-debugNow branch December 9, 2024 15:58
Copy link

github-actions bot commented Dec 9, 2024

🎉 This PR is included in version 1.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants