Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable parameter block for BokehGUI #1552

Closed
wants to merge 1 commit into from
Closed

Enable parameter block for BokehGUI #1552

wants to merge 1 commit into from

Conversation

kkpatel1
Copy link
Member

@mbr0wn mbr0wn added the GRC label Feb 3, 2018
@mbr0wn
Copy link
Member

mbr0wn commented Feb 3, 2018

@skoslowski needs to review this.

@marcusmueller
Copy link
Member

Calling @skoslowski on this, I know your time is sparse, but I'd really love to merge Kartik's code.

haakov
haakov requested changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@haakov haakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to be redone, it's for 3.7/Cheetah.

@mbr0wn
Copy link
Member

mbr0wn commented Jan 8, 2020

Hm that's too bad. Well we'll close this PR for now. @kartikp1995 can you please rebase it?

@mbr0wn mbr0wn closed this Jan 8, 2020
@kkpatel1
Copy link
Member Author

kkpatel1 commented Jan 8, 2020

Sure. I will look into porting gr-bokehGUI to GR 3.8 sometime this semester. Thanks.

@Notou Notou mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakov haakov haakov requested changes

@skoslowski skoslowski Awaiting requested review from skoslowski

Assignees
No one assigned
Labels
GRC Needs Rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kkpatel1 @mbr0wn @marcusmueller @haakov @noc0lour