Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index: Fix volk_get_index #519

Closed
wants to merge 3 commits into from
Closed

index: Fix volk_get_index #519

wants to merge 3 commits into from

Commits on Jan 14, 2023

  1. index: Fix volk_get_index 

    This function results in an infinite loop on Debian 11 for some impls.
This is a first step to fix it.

Fix gnuradio#516

Signed-off-by: Johannes Demel <[email protected]>
    @jdemel
    jdemel committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    c452aec View commit details
    Browse the repository at this point in the history

  2. index: Restructure volk_get_index 

    Instead of recursively calling `volk_get_index`, a new function is
introduced to walk through the list of impls. Then, we introduce a three
step process:
1. Search for the requested impl. Return index if found.
2. Search for the generic impl. Return index if found.
3. Return `-1` and put the burden on the caller.

Signed-off-by: Johannes Demel <[email protected]>
    @jdemel
    jdemel committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    8fe7ed8 View commit details
    Browse the repository at this point in the history

  3. index: Revert to !strncmp 

    This fix is a bit of a guess. aarch64, MacOS, and Win CI tests all fail
after I changed the comparison from `!` to `!= 0`.

Signed-off-by: Johannes Demel <[email protected]>
    @jdemel
    jdemel committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    c1ed567 View commit details
    Browse the repository at this point in the history