Prefer NEON kernels over ORC #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clayton Smith <[email protected]>
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
Prefer NEON kernels over ORC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ORC appears below NEON in
archs.xml, which means that ORC kernels will be preferred ifvolk_profilehas not been executed to profile the kernels. As noted in #639 (comment), in most cases NEON kernels outperform ORC kernels (sometimes by a significant margin), so I think it makes sense to move NEON below ORC. This will also have the side benefit of mostly resolving #622, because the ORC kernels that are broken on ARM (volk_32f_sqrt_32f_a_orc_implandvolk_32fc_magnitude_32f_a_orc_impl) will no longer be selected by default, and are unlikely to be selected byvolk_profileas they are significantly slower than their NEON counterparts.