Decrease the range for signed 16-bit integer testing #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clayton Smith <[email protected]>
That's correct; this will slightly reduce the effectiveness of testing for all kernels with 16i inputs, but I think it's better than having a flaky test which causes CI to be ignored. Hopefully we can come up with a proper fix for #676, after which the full range of 16i values can be tested. |
Alesha72003
pushed a commit
to Alesha72003/volk
that referenced
this pull request
May 15, 2024
Decrease the range for signed 16-bit integer testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates #676.
The
qa_volk_16ic_x2_dot_prod_16ictest is now the most frequent source of CI failures which does not already have an open pull request. Thevolk_16ic_x2_dot_prod_16ickernel was added in #77, and because it does not handle integer overflow consistently, the test suite was modified at that time to limit signed 16-bit integer testing to the range -7 .. +7. Unfortunately, this is not sufficient to prevent overflows in theqa_volk_16ic_x2_dot_prod_16ic.It would be quite a bit of work to rewrite the
volk_16ic_x2_dot_prod_16ickernel to have consistent overflow handling between the protokernels, so I'm proposing to decrease the signed integer range slightly (to -6 .. +6). This does not remove test failures entirely, but reduces the failure rate by about 50x.