Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test neonv7 protokernels on armv7 #726

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

argilo
Copy link
Member

@argilo argilo commented Dec 15, 2023

The neon/neonv7 kernels are not built or tested in CI, because a toolchain file is not passed to CMake. Here I've added one. I had to change the compiler to the OS default, because the toolchain file specifies:

set(CMAKE_CXX_COMPILER g++)
set(CMAKE_C_COMPILER  gcc)

@argilo
Copy link
Member Author

argilo commented Dec 15, 2023

If desired, we could add configurations to test other toolchain files as well.

@jdemel
Copy link
Contributor

jdemel commented Dec 17, 2023

Thanks for this PR. It'd be great to test our toolchain files. We had issues regarding them in the past that were difficult to answer. Tests might give an indicator on how to use them etc.

Copy link
Contributor

@jdemel jdemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was worried for a bit that the cmakeargs part would interfere but this shouldn't be a problem in case it is left empty.

@argilo
Copy link
Member Author

argilo commented Dec 17, 2023

Yes, that should be fine. From GitHub's docs:

If a configuration variable has not been set, the return value of a context referencing the variable will be an empty string.

@jdemel jdemel merged commit 863aff5 into gnuradio:main Jan 7, 2024
33 checks passed
Alesha72003 pushed a commit to Alesha72003/volk that referenced this pull request May 15, 2024
Build and test neonv7 protokernels on armv7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants