Add removeObserver:fromObjectsAtIndexes:forKeyPath:context: method #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredkiefer
reviewed
Oct 1, 2023
Source/NSKeyValueObserving.m
Outdated
| @@ -1325,6 +1325,13 @@ - (void) removeObserver: (NSObject*)anObserver | |||
| [iLock unlock]; | |||
| } | |||
|
|
|||
| - (void) removeObserver: (NSObject*)anObserver | |||
There was a problem hiding this comment.
Why do we have this method here? We don't define the method without context neither and we also don't have the corresponding add methods.
There was a problem hiding this comment.
It doesn't belong there... I discovered the method should only exist where I have it implemented now, as a category on NSArray.
|
@fredkiefer @rfm The tests are passing now. One of the url tests seems to fail intermittently. |
gcasa
force-pushed
the
NSKeyValueObserving_issue327
branch
from
9b5d853
to
1aa2126
Compare
gcasa
force-pushed
the
NSKeyValueObserving_issue327
branch
from
39469c9
to
19cfd59
Compare
|
@rfm @fredkiefer any added feedback? |
Thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new methods and some tests for KVO.