Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSApplication: toggle title of menu item "Hide" on user action. #302

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

trunkmaster
Copy link
Member

Toggle title of menu item "Hide" to "Unhide" and vice versa.
Right-click app menu on hidden app icon should show "Unhide" on menu item and behave respectively.

…versa.

Right-click app menu on hidden app icon should show "Unhide" on menu item and behave respectively.
Source/NSApplication.m Outdated Show resolved Hide resolved
…nging

title and action of NSMenuItem object.
Copy link
Member

@fredkiefer fredkiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still unsure whether the name should be Unhide or Show. If you insist on Unhide, then we should change all the places where Show is currently used.

@trunkmaster
Copy link
Member Author

"Show" is OK - fixed.

@trunkmaster trunkmaster merged commit 5cd4323 into gnustep:master Nov 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants